pt 1 of restructuring ceph RGW #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klgill
force-pushed
the
BetaDocs-MigratingCephRGW
branch
from
692b3a2 to
0c25066
Compare
fmount
reviewed
Apr 18, 2024
| @@ -74,6 +76,8 @@ ifeval::["{build}" == "downstream"] | |||
| :OpenShift: Red Hat OpenShift Container Platform | |||
| :OpenShiftShort: RHOCP | |||
| :OpenStackPreviousInstaller: director | |||
| :Ceph: Red Hat Ceph Storage | |||
| :CephCluster: Red Hat Ceph Storage | |||
There was a problem hiding this comment.
are Ceph and CephCluster referencing the same content? (wondering if we can use the same variable then)
There was a problem hiding this comment.
They are downstream, but we can't call a cluster a "Red Hat Ceph Storage" cluster upstream. I'm not sure if a cluster should be called "Ceph Storage" upstream, or just "Ceph."
docs_user/modules/proc_completing-prerequisites-for-migrating-ceph-rgw.adoc
Outdated
Show resolved
Hide resolved
docs_user/modules/proc_migrating-mon-and-mgr-from-controller-nodes.adoc
Outdated
Show resolved
Hide resolved
rheslop
reviewed
Apr 19, 2024
klgill
force-pushed
the
BetaDocs-MigratingCephRGW
branch
from
0c25066 to
e2c368f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fmount I included some comments and questions in the files the same way as in the other PR (//kgilliga:)
Peer reviewers (writers): Please make sure that you use the Adoption Beta Peer Review Checklist (https://docs.google.com/document/d/1hxKJdhGNqSOTg6WrbYjJaQIWDu7x5cl2QRYJ7G0HFt8/edit).