Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds template for OpenStackVersion for container registry and tag over… #415
Adds template for OpenStackVersion for container registry and tag over… #415
Changes from all commits
1c9b6feFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from manila/cinder the rest are good e.g. https://logserver.rdoproject.org/95/52995/2/check/periodic-data-plane-adoption-osp-17-to-extracted-crc/f7c0a71/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/nova-api-0/nova-api-0-describe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cinder and manila-share still have an issue - otherwise this is good \o/
https://logserver.rdoproject.org/95/52995/2/check/periodic-data-plane-adoption-osp-17-to-extracted-crc/f7c0a71/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/cinder-volume-volume1-0/cinder-volume-volume1-0-describe
and https://logserver.rdoproject.org/95/52995/2/check/periodic-data-plane-adoption-osp-17-to-extracted-crc/f7c0a71/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/manila-share-share1-0/manila-share-share1-0-describe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprince o/ hello any idea what I'm missing for those two please? ^^
the OpenStackVersion we end up with is there https://logserver.rdoproject.org/95/52995/2/check/periodic-data-plane-adoption-osp-17-to-extracted-crc/f7c0a71/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/openstackversions.core.openstack.org/openstack.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @marios, I suspect the problem is that manila and cinder-volume should match the instance name, otherwise the default container is used. By matching the instance name I mean that if there's a share called
share1, you should have theshare1entry in the openstackVersions CR, if you have a cinder-volume calledceph, you should have the same entry in the openstackVersions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking @fmount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However this is weird, as per [1] I would expect the
defaultimage there, so you don't need to explicitly define an entry.From
OpenStackVersionslogs [2] you can still see references of thequay.iorelated images, and I suspect the problem is that the current deployed version is 0.0.1, so the default images for cinder and manila are get from:which I think we don't have in the current template.
[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/openstack/manila.go#L123
[2] https://logserver.rdoproject.org/95/52995/2/check/periodic-data-plane-adoption-osp-17-to-extracted-crc/f7c0a71/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/openstackversions.core.openstack.org/openstack.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again for checking
we could easily test the version theory by including the version in the template (even hard-coded for the test) and if it works I can add a task to determine the current version to apply to the template.
I'd still push to merge this and I can iterate for this bit