Adding basic pre-commit to the repo #440
Conversation
|
Should we also add Any test that is not enforced by the CI will get broken eventually i think :) |
jpodivin
force-pushed
the
pre-commit
branch
2 times, most recently
from
4abfc0b to
f5974c4
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
PR has expanded considerably due to the CI integration. But I've minimized changes to actually executable code by skipping bash checks for all ".bash" files. It seems to me that at least some of them are just templates. |
| xref:comparing-configuration-files-between-deployments_storage-requirements[Comparing configuration files between deployments]. | ||
| Make sure you have pull the os-diff repository and configure according to your environment: | ||
| link:planning.md#Configuration tooling[Configure os-diff] | ||
| //kgilliga: Should we use this link in the downstream guide? |
There was a problem hiding this comment.
This is reverting a recent fix
| @@ -130,7 +130,3 @@ ${BASH_ALIASES[openstack]} server list | grep -qF '| test | SHUTOFF |' && ${BASH | |||
| ${BASH_ALIASES[openstack]} server list | grep -F '| test | ACTIVE |' && \ | |||
| ${BASH_ALIASES[openstack]} server --os-compute-api-version 2.48 show --diagnostics test --fit-width -f json | jq -r '.state' | grep running || echo FAIL | |||
| ---- | |||
|
|
|||
There was a problem hiding this comment.
It's not visible in the "discussion" view on the PR but if you open the file detail it will be visible what it's removing.
Checks include basic style and ansible-lint Ansible-lint entry point includes override for the ANSIBLE_ROLES_PATH var, to ensure repo only roles load at runtime. Bash checks on files matching ".*.bash" are disabled as they are often not scripts but rather templates. Linting was applied to all other files. Github action was simplified so that from now on pre-commit takes care of everythin. Signed-off-by: Jiri Podivin <[email protected]>
Checks include basic style and ansible-lint
Ansible-lint entry point includes override for the ANSIBLE_ROLES_PATH var, to ensure repo only roles load at runtime.