Switch Maria IP to internal #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jistr
reviewed
May 14, 2024
holser
force-pushed
the
switch_mysql_to_internal_ip
branch
from
be1ced1 to
d27d16e
Compare
Use internal MariaDB address for data transfer during adoption to prevernt any possible security leaks Closes: OSPRH-6584
holser
force-pushed
the
switch_mysql_to_internal_ip
branch
from
d27d16e to
8f65580
Compare
jistr
approved these changes
May 15, 2024
|
Thanks, i'll merge this ahead of the CI changes, we need to be moving in this direction anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use internal MariaDB address for data transfer during adoption to prevernt any possible security leaks
Closes: OSPRH-6584