Get AEE runner from OpenstackVersion #469
Conversation
| @@ -5,6 +5,7 @@ metadata: | |||
| namespace: openstack | |||
| spec: | |||
| customContainerImages: | |||
| ansibleeeImage: {{ ansibleee_runner_img | default('quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest')}} | |||
There was a problem hiding this comment.
| ansibleeeImage: {{ ansibleee_runner_img | default('quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest')}} | |
| {% if not skip_patching_ansibleee_csv is defined or not skip_patching_ansibleee_csv | bool %} | |
| ansibleeeImage: {{ ansibleee_runner_img | default('quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest')}} | |
| {% endif %} |
There was a problem hiding this comment.
We need something a bit more complex here. Using the variable skip_patching_ansibleee_csv we could skip setting the ansible-runner image and rely on the operator default, which we used when testing beta downstream, we need some jinja templating here to retain the functionality. I left a suggestion inline, but we'd still need to test it
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/aa82c5d2399f40f7ab30ee20efa398fa ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 32m 24s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4f766037a37f405a83b7f58b44fef989 ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 29m 41s |
|
the failure is unrelated to this PR |
ref: openstack-k8s-operators/ci-framework#1580 Signed-off-by: Fabricio Aguiar <[email protected]>
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c3604e9bd59e4e37abb7b237c37ea1ca ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 20m 22s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4f91e7fb34d8412c9415f6342792a064 ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 32m 15s |
There was a problem hiding this comment.
looks OK, but wondering if the non-ceph job failure is related? I don't think so but it has not passed on this patch? Perhaps we have a new issue/cix there @cescgina do you know?
i hit this issue when developing the multinode (it was rabbit related at that time, but might be something else in this case)
* TASK [dataplane_adoption : wait for cell1 Nova compute EDPM services version updated] ***
* fatal: [localhost]: FAILED! => {"attempts": 20, "changed": true, "cmd": "set -euxo pipefail\n\n\nPODIFIED_MARIADB_IP=10.217.5.136\nPODIFIED_CELL1_MARIADB_IP=10.217.5.132\nPODIFIED_DB_ROOT_PASSWORD=\"12345678\"\n\n# The CHARACTER_SET and collation should match the source DB\n# if the do not then it will break foreign key relationships\n# for any tables that are created in the future as part of db sync\nCHARACTER_SET=utf8\nCOLLATION=utf8_general_ci\n\noc exec openstack-cell1-galera-0 -c galera -- mysql -rs -uroot -p$PODIFIED_DB_ROOT_PASSWORD -e \"select a.version from nova_cell1.services a join nova_cell1.services b where a.version!=b.version and a.binary='nova-compute';\"\n", "delta": "0:00:00.246207", "end": "2024-05-27 21:50:31.918957", "msg": "", "rc": 0, "start": "2024-05-27 21:50:31.672750", "stderr": "+ PODIFIED_MARIADB_IP=10.217.5.136\n+ PODIFIED_CELL1_MARIADB_IP=10.217.5.132\n+ PODIFIED_DB_ROOT_PASSWORD=12345678\n+ CHARACTER_SET=utf8\n+ COLLATION=utf8_general_ci\n+ oc exec openstack-cell1-galera-0 -c galera -- mysql -rs -uroot -p12345678 -e 'select a.version from nova_cell1.services a join nova_cell1.services b where a.version!=b.version and a.binary='\\''nova-compute'\\'';'", "stderr_lines": ["+ PODIFIED_MARIADB_IP=10.217.5.136", "+ PODIFIED_CELL1_MARIADB_IP=10.217.5.132", "+ PODIFIED_DB_ROOT_PASSWORD=12345678", "+ CHARACTER_SET=utf8", "+ COLLATION=utf8_general_ci", "+ oc exec openstack-cell1-galera-0 -c galera -- mysql -rs -uroot -p12345678 -e 'select a.version from nova_cell1.services a join nova_cell1.services b where a.version!=b.version and a.binary='\\''nova-compute'\\'';'"], "stdout": "57", "stdout_lines": ["57"]}
comes from there
same issue found on another pull request so looks like cix |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7c70998ed34747b5865eec235ace0d37 ❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3s |
|
recheck mainly i want to see if this NODE_FAILURE is a real thing (only 2 from yestreday https://review.rdoproject.org/zuul/builds?job_name=data-plane-adoption-osp-17-to-extracted-crc&skip=0) I don't think we really need to re-run here - it was tested in testproject and seen to do the right thing. I think we can force merge it today. the non-ceph issue is being tracked with https://issues.redhat.com/browse/OSPCIX-307 which may be fixed now (openstack-k8s-operators/ci-framework#1757) |
There was a problem hiding this comment.
Thanks for the changes! I tested this in https://review.rdoproject.org/r/c/testproject/+/53274 and it works. Job is green https://review.rdoproject.org/zuul/build/9c7a3f56623c41248a790136c29a4aea, using ansiblee-runner image from https://logserver.rdoproject.org/74/53274/2/check/data-plane-adoption-osp-17-to-extracted[…]/controller/ci-framework-data/artifacts/edpm-ansible.yml, as shown in https://logserver.rdoproject.org/74/53274/2/check/data-plane-adoption-osp-17-to-extracted[…]w6q/configure-network-openstack-openstack-s8w6q-describe Image: quay.rdoproject.org/openstack-k8s-operators/openstack-ansibleee-runner:a6745373e2a7d680c2279345917e6803e352be98
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d0549132a8c242f19cd12fd3a27250ee ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 28m 55s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/269abd60e7424481a2c3ce775ec66ae0 ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 32m 41s |
ref: openstack-k8s-operators/ci-framework#1580