Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ceph-hci-pre service when using ceph #478

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented Jun 3, 2024

When trying to run tempest tests with the standalone jobs, we found that after the edpm deployment, the firewall was blocking access to the ceph monitors, adding this service should configure the firewall to allow the traffic to the mons.

@@ -355,6 +355,7 @@
- configure-os
- run-os
- install-certs
- ceph-hci-pre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, if Ceph is part of the deployment we need the firewall in place. However I think this might apply to standalone only, because in multinode we're not going to enroll the Controllers as edpm nodes, right? In any case it doesn't hurt, I'm just wondering if we want to put a comment to explain why we need that and which is the use case / scenario we're covering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely enroll Controllers as Networker nodes though.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/49b5e6e5b8c2427b983561363b565aa6

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 57m 01s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 1h 58m 12s

@frenzyfriday
Copy link
Contributor

Thanks, testing here https://review.rdoproject.org/r/c/testproject/+/53007

@frenzyfriday
Copy link
Contributor

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9290ac2486b1404098825fe917df7e75

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 59m 56s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 1h 56m 01s

@frenzyfriday
Copy link
Contributor

/lgtm

The jobs passed in TP: https://review.rdoproject.org/zuul/build/9501b596ab534ddfbc8df33abecd564f with this patch as depends on

@fmount
Copy link
Contributor

fmount commented Jun 7, 2024

@cescgina do you want to rebase and remove the work in progress label?

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cescgina cescgina marked this pull request as ready for review June 7, 2024 08:23
@cescgina cescgina force-pushed the add_ceph_hci_pre branch from 9bc5ed7 to 4c2511a Compare June 7, 2024 08:23
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/92e9091bb21149eba334a4e6fd33c904

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 32m 05s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 36m 04s

@cescgina
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ad5e099923b349079127f7bfa7378724

✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 32m 42s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 31m 50s

@cescgina
Copy link
Contributor Author

recheck

@@ -355,6 +355,7 @@
- configure-os
- run-os
- install-certs
- ceph-hci-pre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely enroll Controllers as Networker nodes though.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ccb8373cb2bd40b9bf4ec32570a91b1b

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 09m 43s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 18m 36s

@cescgina
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ea3d1267a73e4613bcebd4c1385f4494

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 07m 40s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 18m 21s

@cescgina
Copy link
Contributor Author

recheck

@marios marios merged commit c101275 into openstack-k8s-operators:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants