-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ceph-hci-pre service when using ceph #478
Add ceph-hci-pre service when using ceph #478
Conversation
@@ -355,6 +355,7 @@ | |||
- configure-os | |||
- run-os | |||
- install-certs | |||
- ceph-hci-pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me, if Ceph is part of the deployment we need the firewall in place. However I think this might apply to standalone only, because in multinode we're not going to enroll the Controllers as edpm nodes, right? In any case it doesn't hurt, I'm just wondering if we want to put a comment to explain why we need that and which is the use case / scenario we're covering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will likely enroll Controllers as Networker nodes though.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/49b5e6e5b8c2427b983561363b565aa6 ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 57m 01s |
Thanks, testing here https://review.rdoproject.org/r/c/testproject/+/53007 |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9290ac2486b1404098825fe917df7e75 ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 59m 56s |
/lgtm The jobs passed in TP: https://review.rdoproject.org/zuul/build/9501b596ab534ddfbc8df33abecd564f with this patch as depends on |
@cescgina do you want to rebase and remove the work in progress label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
9bc5ed7
to
4c2511a
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/92e9091bb21149eba334a4e6fd33c904 ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 32m 05s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ad5e099923b349079127f7bfa7378724 ✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 32m 42s |
recheck |
@@ -355,6 +355,7 @@ | |||
- configure-os | |||
- run-os | |||
- install-certs | |||
- ceph-hci-pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will likely enroll Controllers as Networker nodes though.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ccb8373cb2bd40b9bf4ec32570a91b1b ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 09m 43s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ea3d1267a73e4613bcebd4c1385f4494 ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 07m 40s |
recheck |
When trying to run tempest tests with the standalone jobs, we found that after the edpm deployment, the firewall was blocking access to the ceph monitors, adding this service should configure the firewall to allow the traffic to the mons.