-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
began refining the OVN procedure #539
began refining the OVN procedure #539
Conversation
e28ee3d
to
fc49aa7
Compare
+ | ||
[source,yaml] | ||
---- | ||
oc patch openstackcontrolplane openstack --type=merge --patch ' | ||
$ oc patch openstackcontrolplane openstack-galera-network-isolation --type=merge --patch ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 5: Should the number of replicas be 1?
https://github.com/openstack-k8s-operators/architecture/pull/305/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be set like that already, this step is just to update it from "enabled: false" to "enabled:true"
@@ -212,25 +210,27 @@ spec: | |||
' | |||
---- | |||
|
|||
. If you'd like to run OVN gateway services on OCP nodes, also enable the control plane `ovn-controller` service: | |||
. Optional: To run OVN gateway services on {OpenShiftShort} nodes, enable the control plane `ovn-controller` service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 11: Is this step actually optional? Or is it conditional, i.e., it only applies to customers who have OVN gateway services on OCP nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latter, it only applies to the users who have OVN gateways on OCP nodes
* `NetworkAttachmentDefinition` custom resources (CRs) for the original cluster are defined. Specifically, the `internalapi` network is defined. | ||
* Ensure that the original {networking_first_ref} and OVN `northd` are not running. | ||
* Ensure that there is network routability between the control plane services and the adopted cluster. | ||
* Define the following shell variables. Replace the example values with values that are correct for your environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one more prerequisite which we never mentioned I think and this is that You have to be on the ML2/OVN already. It may be kind of obvious but in OSP 17.1 ML2/OVS is still supported backend so it has to be migrated to ML2/OVN before adoption to RHOSO will be started. I created Jira https://issues.redhat.com/browse/OSPRH-8725 but didn't had time to do it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, for now I added the following prerequisite:
The cloud is migrated to the Modular Layer 2 plug-in with Open Virtual Networking (ML2/OVN) mechanism driver.
@@ -24,23 +21,22 @@ ifeval::["{build}" == "downstream"] | |||
STORAGE_CLASS=local-storage | |||
OVSDB_IMAGE=registry.redhat.io/rhosp-dev-preview/openstack-ovn-base-rhel9:18.0 | |||
endif::[] | |||
SOURCE_OVSDB_IP=172.17.1.49 | |||
SOURCE_OVSDB_IP=172.17.0.100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change of IP? It isn't any problem for me, I am just curious :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slawqo I'm sorry, I should've explained. This was a minor suggestion from Jiri to align with the rest of the examples in the guide. This is his comment from hackfest: https://docs.google.com/document/d/17GzJf8uTfpe7TJrEpf9NomZ98LcnNvUs2V3j9jgDw2w/edit?disco=AAABOWBvSeI
+ | ||
[source,yaml] | ||
---- | ||
oc patch openstackcontrolplane openstack --type=merge --patch ' | ||
$ oc patch openstackcontrolplane openstack-galera-network-isolation --type=merge --patch ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be set like that already, this step is just to update it from "enabled: false" to "enabled:true"
@@ -212,25 +210,27 @@ spec: | |||
' | |||
---- | |||
|
|||
. If you'd like to run OVN gateway services on OCP nodes, also enable the control plane `ovn-controller` service: | |||
. Optional: To run OVN gateway services on {OpenShiftShort} nodes, enable the control plane `ovn-controller` service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latter, it only applies to the users who have OVN gateways on OCP nodes
bec7b3d
to
339224d
Compare
LGTM |
https://issues.redhat.com/browse/RHOSPDOC-1926
@booxter or @slawqo Can you please review my edits to the procedure and answer the 2 questions I put in this PR? Thanks!