Use os_user variable in development_environment role #545
Conversation
archana203
changed the title
|
recheck |
|
/lgtm |
archana203
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/34c1625d08594700bdea901febb9d828 ❌ adoption-standalone-to-crc-ceph FAILURE in 2h 10m 16s |
|
recheck |
| @@ -6,10 +6,11 @@ | |||
| EDPM_PRIVATEKEY_PATH: "{{ edpm_privatekey_path }}" | |||
| OS_CLOUD_IP: "{{ standalone_ip | default(edpm_node_ip) }}" | |||
| OS_CLOUD_NAME: "{{ os_cloud_name }}" | |||
| OS_USER: "{{ os_user }}" | |||
There was a problem hiding this comment.
There is a "OS_USERNAME" variable which means "the user account in OpenStack that is used for API calls". To avoid confusion with that one, i think we should probably call this something like "EDPM_SSH_USER"? But let's first run through the test whether this can fix the RHEL job before we rename? Or i'd be even ok landing this and then renaming in a follow-up PR.
There was a problem hiding this comment.
Actually yes let's land this and rename in a follow-up. Sorry i didn't realize this on the first pass of the review :)
There was a problem hiding this comment.
EDPM_SSH_USER seems to be an user used to ssh compute nodes. Here, we are doing ssh to the node from where we can access the openstack cloud configs to generate a token.
There was a problem hiding this comment.
Fair enough, but personally i'd still at least include "SSH" later, to not be too close to the openstack client vars: https://docs.openstack.org/newton/user-guide/common/cli-set-environment-variables-using-openstack-rc.html
Not something that needs to change right now anyway :)
There was a problem hiding this comment.
OS_USER_SSH sounds good though
There was a problem hiding this comment.
I echo with what Jiri commented, anything with OS_ prefix should be reserved only to OpenStack related environment variable.
There was a problem hiding this comment.
What about OSP_SSH_USER ?
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7432672aad714c94a12f627da2f7f33b ❌ adoption-standalone-to-crc-ceph FAILURE in 1h 29m 33s |
|
recheck |
For the HA RHEV env, we are using a non-root user for accessing the source cloud.