Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] correct ceph adoption prerequisites #745

Merged

Conversation

katarimanojk
Copy link
Contributor

@katarimanojk katarimanojk commented Nov 25, 2024

update ceph rgw, rbd and nfs prerequisites steps in the adoption document.

Jira: https://issues.redhat.com/browse/OSPRH-11496

@katarimanojk katarimanojk requested a review from fmount November 25, 2024 11:44
@katarimanojk katarimanojk force-pushed the adoption_ceph_prereq_updates branch from 8f3364e to a684d13 Compare November 25, 2024 11:52
@fmount fmount requested a review from klgill November 25, 2024 12:20
Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few edits.

@klgill
Copy link
Contributor

klgill commented Nov 25, 2024

Note to self: After this PR is merged, I need to copy the updated files downstream and republish the adoption guide.

Copy link
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off merge for addressing reviews but overall LGTM.

@katarimanojk katarimanojk requested a review from fmount December 6, 2024 07:27
@katarimanojk katarimanojk force-pushed the adoption_ceph_prereq_updates branch 2 times, most recently from afbfe18 to 1ddc28b Compare December 11, 2024 12:06
@katarimanojk katarimanojk requested a review from klgill December 11, 2024 12:08
Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment.

update ceph rgw ,rbd and nfs prerequisites steps in
the adoption document.

Jira: https://issues.redhat.com/browse/OSPRH-11496
@katarimanojk katarimanojk force-pushed the adoption_ceph_prereq_updates branch from 1ddc28b to 1bcb6c8 Compare December 12, 2024 05:22
@katarimanojk katarimanojk requested a review from klgill December 12, 2024 05:27
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jistr jistr merged commit 7c34bd9 into openstack-k8s-operators:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants