Add predictable IPs to mdns and bind9 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beagles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
beagles
force-pushed
the
bind-predictable-ips
branch
from
93dca98 to
af5b0b2
Compare
beagles
changed the title
omersch381
reviewed
Nov 11, 2024
beagles
force-pushed
the
bind-predictable-ips
branch
from
a006b5f to
7031096
Compare
|
PR still needs updating for the changes how the mdns map has been defined. Standby. |
beagles
force-pushed
the
bind-predictable-ips
branch
from
7031096 to
31004a0
Compare
|
pre-commit check file has been updated, let's try to retest |
|
/retest |
beagles
force-pushed
the
bind-predictable-ips
branch
5 times, most recently
from
fc2bbeb to
c803892
Compare
|
/test designate-operator-build-deploy-kuttl |
beagles
force-pushed
the
bind-predictable-ips
branch
2 times, most recently
from
6934243 to
d11464a
Compare
This PR adds support for mounting generated predictable IPs and employing them in the relevant pods.
beagles
force-pushed
the
bind-predictable-ips
branch
from
d11464a to
2babf83
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit c44a879
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the predictable IPs to the pod volumes as well as adding some hash tracking logic to the controller.
Note requires availability of openstack-k8s-operators/tcib#218