Move to VerifySecret when checking the ctlplane secret #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
verify-secret
branch
from
dc32059 to
0ab0087
Compare
This change aligns the glance-operator to what has been done in cinder and manila. The ensureSecret function has been renamed to verifyServiceSecret and it takes as input the configVars where the hash is computed. Signed-off-by: Francesco Pantano <[email protected]>
fmount
commented
Sep 10, 2024
| @@ -405,14 +404,6 @@ func (r *GlanceReconciler) reconcileInit( | |||
| // | |||
| // create Keystone service and users - https://docs.openstack.org/Glance/latest/install/install-rdo.html#configure-user-and-endpoints | |||
| // | |||
| _, _, err := oko_secret.GetSecret(ctx, helper, instance.Spec.Secret, instance.Namespace) | |||
There was a problem hiding this comment.
I think we don't need this check that we just did a few lines ago
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 50b7ba5
into
openstack-k8s-operators:main
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the
glance-operatorto what has been done incinderandmanila. TheensureSecretfunction has been renamed toverifyServiceSecretand it takesconfigVarsas input where the hash is computed and stored.