Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new lib-common VolumeSource structs #638

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Oct 16, 2024

No description provided.

@fmount
Copy link
Contributor

fmount commented Oct 31, 2024

we need to rebase this patch and land before the bump of go mod

@fmount
Copy link
Contributor

fmount commented Nov 4, 2024

/retest

1 similar comment
@dprince
Copy link
Contributor Author

dprince commented Nov 4, 2024

/retest

@dprince
Copy link
Contributor Author

dprince commented Nov 4, 2024

recheck

@dprince
Copy link
Contributor Author

dprince commented Nov 5, 2024

/retest

pkg/glance/volumes.go Outdated Show resolved Hide resolved
@fmount fmount force-pushed the custom_vol_source branch 2 times, most recently from 01708ab to 437b0be Compare November 6, 2024 21:51
@fmount fmount self-requested a review November 6, 2024 21:52
@fmount
Copy link
Contributor

fmount commented Nov 6, 2024

after CI is green this should be good to go as well.

@fmount
Copy link
Contributor

fmount commented Nov 7, 2024

/test glance-operator-build-deploy-kuttl

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0c38c83 into openstack-k8s-operators:main Nov 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants