Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraMounts functional tests #665

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Dec 3, 2024

This change adds a functional test for the Glance extraMounts. It ensures we're able to validate the abstraction of corev1.VolumeSource struct introduced in lib-common/storage module.

Jira: https://issues.redhat.com/browse/OSPRH-11210

@openshift-ci openshift-ci bot added the approved label Dec 3, 2024
@fmount fmount requested review from konan-abhi and abays and removed request for olliewalsh and frenzyfriday December 3, 2024 13:38
This change adds a functional test for the Glance extraMounts. It
ensures we're able to validate the abstraction of 'corev1.VolumeSource'
struct introduced in lib-common/storage module.

Jira: https://issues.redhat.com/browse/OSPRH-11210

Signed-off-by: Francesco Pantano <[email protected]>
@fmount
Copy link
Contributor Author

fmount commented Dec 5, 2024

/test glance-operator-build-deploy-kuttl

Copy link
Contributor

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fc895f1 into openstack-k8s-operators:main Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants