Skip to content

Commit

Permalink
Fix ContainerImageRegistryCredentials for tripleo
Browse files Browse the repository at this point in the history
Quote the registry username as it may not work otherwise.
Add E003 to ingore list for bashate to make that indentation working.

Signed-off-by: Bohdan Dobrelia <[email protected]>
  • Loading branch information
bogdando committed Dec 17, 2024
1 parent 6ce0c92 commit eed2158
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ repos:
rev: 2.1.1
hooks:
- id: bashate
entry: bashate --error . --ignore=E006,E040,E043
entry: bashate --error . --ignore=E006,E040,E043,E003
4 changes: 2 additions & 2 deletions devsetup/scripts/tripleo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ fi
if [ "\$RH_REGISTRY_USER" ] && [ -n "\$RH_REGISTRY_PWD" ]; then
grep -q ContainerImageRegistryCredentials \$HOME/containers-prepare-parameters.yaml || \
cat >> \$HOME/containers-prepare-parameters.yaml <<__EOF__
ContainerImageRegistryCredentials:
ContainerImageRegistryCredentials:
registry.redhat.io:
\${RH_REGISTRY_USER}: \$RH_REGISTRY_PWD
'\${RH_REGISTRY_USER}': \$RH_REGISTRY_PWD
__EOF__
fi
set -x
Expand Down

0 comments on commit eed2158

Please sign in to comment.