Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yq parameters #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paramite
Copy link
Contributor

@paramite paramite commented Feb 8, 2024

Currently make openstack fails with yq installed via pip (yq 3.2.3). This patch make it work with it again.

Currently `make openstack` fails with yq installed via pip (yq 3.2.3).
This patch make it work with it again.
@openshift-ci openshift-ci bot requested review from fultonj and karelyatin February 8, 2024 11:46
@paramite paramite changed the title Move qy parameters Move yq parameters Feb 8, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c82ae3f2d4214549afcdc2ee41213282

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 42s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 53s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 12m 27s

@paramite
Copy link
Contributor Author

paramite commented Feb 8, 2024

recheck

@jlarriba
Copy link
Contributor

jlarriba commented Feb 8, 2024

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1c48743fed0a4aa3970ebba3ded3ebcb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 43s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 28s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 09m 04s

@fao89
Copy link
Contributor

fao89 commented Feb 9, 2024

recheck

@fao89
Copy link
Contributor

fao89 commented Feb 9, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, paramite

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 9, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3b9d42cf36f743d38083e657ff27b5b4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 25s
install-yamls-crc-podified-edpm-baremetal FAILURE in 25m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 14s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 21m 19s

@paramite
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/923674aabc6c4bda8176a17a40bfba9f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 27s
install-yamls-crc-podified-edpm-baremetal FAILURE in 25m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 58s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 04m 23s

@fao89
Copy link
Contributor

fao89 commented Feb 12, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b00c148c884d48b4bceadec2e05eae67

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 06s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 05s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 08s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 06m 29s

@abays
Copy link
Contributor

abays commented Feb 12, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6cf74109a1474770971173f00fcaca3d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 16s
install-yamls-crc-podified-edpm-baremetal FAILURE in 22m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 01s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 10m 11s

@abays
Copy link
Contributor

abays commented Feb 13, 2024

The baremetal job seems to consistently fail with this error:

 "error: must build at directory: not a valid directory: evalsymlink failure on '/home/zuul/ci-framework-data/artifacts/manifests/operator/baremetal-operator/config' : lstat /home/zuul/ci-framework-data/artifacts/manifests/operator: no such file or directory"

@paramite
Copy link
Contributor Author

Studying the logs more deeply it fails with Error: unknown shorthand flag: 'y' in -y. Apparently version used by CI does not have -y option which unfortunately is required by version available in PIP. How is the job getting yq, so that I can get the same version in my lab? I guess we can give up on this PR until CI gets updated version.

@fao89
Copy link
Contributor

fao89 commented Feb 15, 2024

@ciecierski
Copy link
Contributor

Hello,
@fao89 it is indeed [1] what causes problems. We should use yq from pip, not source. The yq from pip doesn't recognize -y flag, but it works without it just fine.

[1]https://github.com/openstack-k8s-operators/install_yamls/blob/main/devsetup/roles/download_tools/tasks/main.yaml#L116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants