Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README revision #958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpodivin
Copy link
Contributor

Adjust REAME to explicitly state that we have NETWORK_ISOLATION set to true by default, and that it's better to use openstack_deploy_wait target.

This should save newcomers some head scratches.

@openshift-ci openshift-ci bot requested review from abays and karelyatin November 29, 2024 12:24
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/823c6e275da44b82b3dfe00a9b229422

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 43s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 1m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 39s

Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpodivin
Once this PR has been reviewed and has the lgtm label, please ask for approval from karelyatin. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants