Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic DHCP interface configuration #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weinimo
Copy link
Contributor

@weinimo weinimo commented Dec 17, 2024

This fixes issues with make openstack in my environment, in particular with make nncp_with_retries which constantly timed out.

This fixes issues with `make openstack` in my environment, in particular
with `make nncp_with_retries` which constantly timed out.
@weinimo weinimo requested review from abays and karelyatin December 17, 2024 09:12
@openshift-ci openshift-ci bot requested review from slagle and viroel December 17, 2024 09:12
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weinimo
Once this PR has been reviewed and has the lgtm label, please assign karelyatin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weinimo
Copy link
Contributor Author

weinimo commented Dec 17, 2024

Please let me know if I should create a JIRA about this issue.

@karelyatin
Copy link
Contributor

But this PR just removing static bindings but dhcp should still be enabled, will this really help?

@weinimo
Copy link
Contributor Author

weinimo commented Dec 17, 2024

But this PR just removing static bindings but dhcp should still be enabled, will this really help?

IDK how it helps, but I can say that with this make openstack no longer times out waiting for nncp to finish.

@karelyatin
Copy link
Contributor

But this PR just removing static bindings but dhcp should still be enabled, will this really help?

IDK how it helps, but I can say that with this make openstack no longer times out waiting for nncp to finish.

But that would be because i have disabled gateway on your env last time i accessed that, if you still using the same. can confirm with sudo virsh net-dumpxml default

@weinimo
Copy link
Contributor Author

weinimo commented Dec 17, 2024

sudo virsh net-dumpxml default

$ sudo virsh net-dumpxml default
<network connections='2'>
  <name>default</name>
  <uuid>620efb3d-8557-4151-9e7e-055cf0752316</uuid>
  <forward mode='nat'>
    <nat>
      <port start='1024' end='65535'/>
    </nat>
  </forward>
  <bridge name='virbr0' stp='on' delay='0'/>
  <mac address='52:54:00:25:06:7f'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
  </ip>
</network>

@karelyatin
Copy link
Contributor

sudo virsh net-dumpxml default

$ sudo virsh net-dumpxml default
<network connections='2'>
  <name>default</name>
  <uuid>620efb3d-8557-4151-9e7e-055cf0752316</uuid>
  <forward mode='nat'>
    <nat>
      <port start='1024' end='65535'/>
    </nat>
  </forward>
  <bridge name='virbr0' stp='on' delay='0'/>
  <mac address='52:54:00:25:06:7f'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
  </ip>
</network>

Ok so there is no dhcp section i recall i dropped that too as by default it's set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants