Update tls cert secret validation due VerifyCertSecrets() change

[stuggi]

It is depending on: openstack-k8s-operators/lib-common#559 (intentionally changed the wording as meta content provider does not play well with lib-common yet)

Jira: OSPRH-9991

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3b8982e09f8b4e97b4b9357e13858b06

❌ openstack-meta-content-provider FAILURE in 13m 25s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

[gibizer]

Change looks good but I think we have an issue with the content provider as it tries to bump the lib common version into the openstack-operator as well and that fails.

    [1/2] STEP 14/15: RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go
    # github.com/openstack-k8s-operators/openstack-operator/controllers/client
    controllers/client/openstackclient_controller.go:258:34: assignment mismatch: 3 variables but tls.ValidateCACertSecret returns 2 values
    # github.com/openstack-k8s-operators/openstack-operator/pkg/openstack
    pkg/openstack/common.go:251:28: assignment mismatch: 3 variables but validateSecret.ValidateCertSecret returns 2 values
    pkg/openstack/common.go:287:28: assignment mismatch: 3 variables but ed.Service.TLS.GenericService.ValidateCertSecret returns 2 values
    Error: building at STEP "RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go": while running runtime: exit status 1

The provider changed by @raukadah in #850 so we need help from him to fix it.

[gibizer]

recheck

[gibizer]

Change looks good but I think we have an issue with the content provider as it tries to bump the lib common version into the openstack-operator as well and that fails.

    [1/2] STEP 14/15: RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go
    # github.com/openstack-k8s-operators/openstack-operator/controllers/client
    controllers/client/openstackclient_controller.go:258:34: assignment mismatch: 3 variables but tls.ValidateCACertSecret returns 2 values
    # github.com/openstack-k8s-operators/openstack-operator/pkg/openstack
    pkg/openstack/common.go:251:28: assignment mismatch: 3 variables but validateSecret.ValidateCertSecret returns 2 values
    pkg/openstack/common.go:287:28: assignment mismatch: 3 variables but ed.Service.TLS.GenericService.ValidateCertSecret returns 2 values
    Error: building at STEP "RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; env ${GO_BUILD_EXTRA_ENV_ARGS} go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go": while running runtime: exit status 1

The provider changed by @raukadah in #850 so we need help from him to fix it.

Changed the Depends-On wording in the PR message to avoid triggering the meta-content-provider logic based on @raukadah 's suggestion.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cee68fee4301470597aedacb3786855d

❌ openstack-meta-content-provider FAILURE in 12m 31s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

[gibizer]

just reworded the commit message to drop the Depends-On from there too.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/10a363367240402e8e74b8faa13ab55d

❌ openstack-meta-content-provider FAILURE in 13m 40s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

[raukadah]

recheck node hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gibizer,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment