Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default cache config for no tls #910

Merged

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Dec 11, 2024

When env is deployed with tls disabled, cache config was wrong as "dogpile.cache.memcached" backend requires inet[6] prefixes for memcache_servers setting while it was set without the prefix. with IPv4 issue not observed as "inet" is default prefix, this patch fixes it by setting [cache]/memcache_servers based on tls config.

Resolves: OSPRH-12224
Related-Issue: OSPRH-12221

When env is deployed with tls disabled, cache config was
wrong as "dogpile.cache.memcached" backend requires inet[6] prefixes
for memcache_servers setting while it was set without the prefix.
with IPv4 issue not observed as "inet" is default prefix, this
patch fixes it by setting [cache]/memcache_servers based on
tls config.

Resolves: OSPRH-12224
Related-Issue: OSPRH-12221
@openshift-ci openshift-ci bot requested review from bogdando and dprince December 11, 2024 10:45
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bogdando
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b107400 into openstack-k8s-operators:main Dec 12, 2024
7 checks passed
@karelyatin
Copy link
Contributor

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@karelyatin: new pull request created: #913

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants