Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable baremetal deployment with virtualmedia #108

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Enable baremetal deployment with virtualmedia #108

merged 1 commit into from
Nov 28, 2023

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Nov 23, 2023

No description provided.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bd84574dd90b4d62b3a05c28f33d8230

✔️ openstack-baremetal-operator-content-provider SUCCESS in 28m 01s
❌ openstack-baremetal-operator-crc-podified-edpm-baremetal NODE_FAILURE Node request 199-0006664870 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-baremetal-operator for 108,b13301e65172e6b1931072a154bad8d4d25cba3a

@rabi rabi changed the title WIP Hack to test virtualmedia WIP Enable baremetal deployment with virtualmedia Nov 23, 2023
@rabi
Copy link
Contributor Author

rabi commented Nov 23, 2023

/retest

@rabi
Enable baremetal deployment with virtualmedia
7e683c4 
When the bootMode in provisioning resource is either `Unmanaged`
or Disabled, we would notlook for the provisioning interface and
rather boot ramdisk using virtualmedia.Also, use the hostIP to
build the local image url. The only caveat here is that BM network
where the os image is available locally should be routable from the OSP
controlplane network, if we use a different network for OSP
controlplane rather than the BM network.
@rabi rabi changed the title WIP Enable baremetal deployment with virtualmedia Enable baremetal deployment with virtualmedia Nov 24, 2023
@rabi rabi requested a review from abays November 24, 2023 04:18
abays
abays approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 67372c9 into openstack-k8s-operators:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@abays abays

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabi @abays @openshift-merge-robot