Controller runtime update #124
Conversation
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0200bde7fbb74a61bffe6a63cb780b01 ❌ openstack-baremetal-operator-content-provider FAILURE in 5m 58s |
bshephar
force-pushed
the
controller-runtime
branch
from
caa30c4 to
434a48e
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/01136dbecd7d4920b41576749884edb7 ❌ openstack-baremetal-operator-content-provider FAILURE in 5m 57s |
bshephar
force-pushed
the
controller-runtime
branch
from
434a48e to
2ff75d9
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fc19443fadb249248efe28b009ec09b2 ❌ openstack-baremetal-operator-content-provider FAILURE in 6m 00s |
api/go.mod
Outdated
| k8s.io/api v0.26.13 | ||
| k8s.io/apimachinery v0.26.13 | ||
| sigs.k8s.io/controller-runtime v0.14.7 | ||
| k8s.io/api v0.29.1 |
There was a problem hiding this comment.
As commented on slack, we should not bump to a version beyond what the OCP version we're testing with supports.
bshephar
force-pushed
the
controller-runtime
branch
from
2ff75d9 to
a3790e8
Compare
Signed-off-by: Brendan Shephard <[email protected]>
This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <[email protected]>
This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <[email protected]>
This change fixes the Watches declarations to comply with the new controller-runtime standards. Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
controller-runtime
branch
from
a3790e8 to
f35ff1e
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4a2254a1f2b6406e92950961875c277d ❌ openstack-baremetal-operator-content-provider FAILURE in 6m 11s |
bshephar
force-pushed
the
controller-runtime
branch
from
c9332ce to
e715a5d
Compare
Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
controller-runtime
branch
from
e715a5d to
00b391c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar, gibizer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5223d2905df041edb32e86fd90fc7222 ❌ openstack-baremetal-operator-content-provider FAILURE in 6m 57s |
|
@bshephar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This changes updates the controller-runtime and fixes the initialisation of objects to comply with the new controller-runtime standards. Namely:
We fix the function signatures of the webhook to include admissions.Warnings:
kubernetes-sigs/controller-runtime@8770b4d
We fix the initialisation of the manager to declare the webhook following the new schema:
kubernetes-sigs/controller-runtime@91cdd8c
We fix the Watches function to comply with the new signature definition:
kubernetes-sigs/controller-runtime@dc62ed5
Add context to EventHandlers:
kubernetes-sigs/controller-runtime@2464a9d