Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit]Add shared kuttl pre-commit rules #105

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented May 10, 2024

This pre-commit check ensures that no TestAsserts are defined in our kuttl tests that are ignored by kuttl.

This can be then used in the service operators by adding the following to the .pre-commit-config.yaml

- repo: https://github.com/openstack-k8s-operators/openstack-k8s-operators-ci
  hooks:
    - id: kuttl-single-test-assert

This pre-commit check ensures that no TestAsserts are defined in
our kuttl tests that are ignores by kuttl
@gibizer gibizer force-pushed the common-pre-commit-hooks branch from d813d3e to 067099e Compare May 10, 2024 11:00
@viroel
Copy link
Contributor

viroel commented May 10, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, rebtoor, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e30d72f into openstack-k8s-operators:main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants