Add some basic collection for designate service details #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
omersch381
force-pushed
the
add_designate_must_gather
branch
from
02569f4 to
5fc4cb7
Compare
|
Holding this PR until I get at least one review of a Designate team member. |
fmount
reviewed
Dec 19, 2024
omersch381
force-pushed
the
add_designate_must_gather
branch
from
5fc4cb7 to
fcd76ab
Compare
fmount
requested changes
Dec 19, 2024
This patch adds some basic data collection of designate resources.
omersch381
force-pushed
the
add_designate_must_gather
branch
from
fcd76ab to
2fc2005
Compare
|
/lgtm |
|
Designate team is ok with merging the patch the way it is, unholding... |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f73ea20
into
openstack-k8s-operators:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds some basic data collection of designate resources.