Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0-fr1] Provide DatabaseInstance for Octavia if not explicitly set #1233

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 17, 2024

This is an automated cherry-pick of #1222

/assign gthiemonge

JIRA: OSPRH-12243

Several of the operator integrations include a conditional to set a
hardcoded-yet-consistent default DatabaseInstance value if it is not
explicitly set for the component operator. This block was missing from
the Octavia integration.

Jira: OSPRH-12243
@weinimo
Copy link
Contributor

weinimo commented Dec 17, 2024

/lgtm

@weinimo
Copy link
Contributor

weinimo commented Dec 17, 2024

/retest

logger.go:42: 09:39:05 | | Error from server (InternalError): error when creating "https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml": Internal error occurred: failed calling webhook "mnetconfig.kb.io": failed to call webhook: Post "https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s": no endpoints available for service "infra-operator-controller-manager-service" seems unrelated

@jpodivin
Copy link
Contributor

jpodivin commented Jan 3, 2025

/retest

Another unrelated error, this time:

 error: must build at directory: not a valid directory: evalsymlink failure on '/alabama/install_yamls/out/openstack-kuttl-tests/manila/cr' : lstat /alabama/install_yamls/out/openstack-kuttl-tests/manila: no such file or directory 

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1a69d98 into openstack-k8s-operators:18.0-fr1 Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants