Remove use of CtlplaneNetmask #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes use of CtlplaneNetmask in line with the changes proposed in: openstack-k8s-operators/openstack-baremetal-operator#241 Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
no-default-netmask
branch
from
f39669a to
f0a222c
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/openstack-baremetal-operator#241 is needed. |
Bumping the openstack-baremetal-operator version so that we can move towards removal of unnecesasry and no-longer used parameters from the operator. Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
no-default-netmask
branch
from
9bccd15 to
913bdc5
Compare
This is no longer needed for this change to merge. |
hjensas
approved these changes
Jan 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3cca2eb
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes use of CtlplaneNetmask in line with the changes proposed in:
openstack-k8s-operators/openstack-baremetal-operator#241
Jira: https://issues.redhat.com/browse/OSPRH-12686