Add github workflow to build and push watcher operator images #7
Conversation
This is based on nova operator workflow. It will build the images once a pr gets merged. Jira: https://issues.redhat.com/browse/OSPRH-11419 Signed-off-by: Chandan Kumar <[email protected]>
| IMAGENAMESPACE: ${{ secrets.IMAGENAMESPACE }} | ||
| QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} | ||
| QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} | ||
| REDHATIO_USERNAME: ${{ secrets.REDHATIO_USERNAME }} | ||
| REDHATIO_PASSWORD: ${{ secrets.REDHATIO_PASSWORD }} |
There was a problem hiding this comment.
These are Organization secrets available to all repos.
There was a problem hiding this comment.
we also have https://github.com/openstack-k8s-operators/nova-operator/blob/main/.github/workflows/build-operator-dont-publish.yaml in nova
the difference is the build-operator-dont-publish.yaml runs on PRs
the where as this one runs only after the change merges since it runs on "push" to a branch which includes merging pr
i guess since we have the meta content provider we can skip the don't push version so this looks reasonable to me
we also have the prow job to build the images in fips mode so we can probably drop the build-operator-dont-publish.yaml github action form nova now.
There was a problem hiding this comment.
i have not configured the required jobs yet so i put a hold until they report back.
we can configure that shortly
for now ill approve this and when the jobs report back ill drop the hold and test if the tide integration is working correctly.
note while your are correct about the org secret and that this workflow you should work the only think I'm unsure about is do we need to manually create the image repo in quay.io first
we can only test that after this merges.
if the post merge action fails we can create the image and retirgger it or wait for the next patch to build and push the image.
| IMAGENAMESPACE: ${{ secrets.IMAGENAMESPACE }} | ||
| QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} | ||
| QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} | ||
| REDHATIO_USERNAME: ${{ secrets.REDHATIO_USERNAME }} | ||
| REDHATIO_PASSWORD: ${{ secrets.REDHATIO_PASSWORD }} |
There was a problem hiding this comment.
we also have https://github.com/openstack-k8s-operators/nova-operator/blob/main/.github/workflows/build-operator-dont-publish.yaml in nova
the difference is the build-operator-dont-publish.yaml runs on PRs
the where as this one runs only after the change merges since it runs on "push" to a branch which includes merging pr
i guess since we have the meta content provider we can skip the don't push version so this looks reasonable to me
we also have the prow job to build the images in fips mode so we can probably drop the build-operator-dont-publish.yaml github action form nova now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amoralej, marios, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @SeanMooney for the review and comments. Since this pr makes changes to Tide tries to make sure all the jobs running against a pr needs to pass otherwise it will not merge. Need your views on this, thank you! |
instead of removing the requirement. we can just override the job is this case. |
|
/override rdoproject.org/github-check github-check is a no run for this PR |
|
@viroel: Overrode contexts on behalf of viroel: rdoproject.org/github-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ah, yes correct @viroel , I forgot about this, thank you :-) |
openshift-merge-bot
bot
merged commit 9ca2cca
into
openstack-k8s-operators:main
|
So what we should do is add the a noop job and have that run on the files that are filtered out for the other jobs. That's what we do in the cloud ops jobs |
This is based on nova operator workflow. It will build the images once a pr gets merged.
Jira: https://issues.redhat.com/browse/OSPRH-11419