Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue with cmd + s on status-page/new form #916

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Ipriyankrajai
Copy link
Contributor

Type of change

  • 🐛 Bug fix

Description

Moved checkUniqueSlug funtion to onSubmit function.

Fixes #914

Before this PR

There was no validation for api on status page when you use cmd + s to save

After this PR

It will check for validation even if you use cmd + s to save

Copy link

vercel bot commented Jul 5, 2024

@Ipriyankrajai is attempting to deploy a commit to the OpenStatus Team on Vercel.

A member of the Team first needs to authorize it.

@Ipriyankrajai Ipriyankrajai changed the title Fix: issue with cmd + save Fix: issue with cmd + s on status-page/new form Jul 5, 2024
Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openstatus-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:06pm

Copy link
Member

@mxkaske mxkaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ipriyankrajai!

apps/web/src/components/forms/status-page/form.tsx Outdated Show resolved Hide resolved
@thibaultleouay
Copy link
Member

Thanks again @Ipriyankrajai

@thibaultleouay thibaultleouay merged commit e8c5118 into openstatusHQ:main Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When saving monitor, using the keyboard shortcut Cmd + S it should run the checks
3 participants