fix checking nil books_used_details (#1206)

openstax · Oct 5, 2023 · 2b333ba · 2b333ba
1 parent e142ed9
commit 2b333ba
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/app/handlers/newflow/educator_signup/complete_profile.rb b/app/handlers/newflow/educator_signup/complete_profile.rb
@@ -143,7 +143,7 @@ def books_used
       end
 
       def books_used_details
-        signup_params.books_used_details.reject do |k, v|
+        (signup_params.books_used_details || {}).reject do |k, v|
           k.blank? || v.dig('how_using_book').blank? || v.dig('num_students_using_book').blank?
         end
       end

diff --git a/spec/handlers/newflow/educator_signup/complete_profile_spec.rb b/spec/handlers/newflow/educator_signup/complete_profile_spec.rb
@@ -50,6 +50,25 @@ module EducatorSignup
           }
         end
 
+        context 'with a different profile' do
+          let(:params) do
+            {
+              signup: {
+                school_name: 'School Name',
+                books_of_interest: ['Test Book'],
+                books_used: ['Test Book'],
+                using_openstax_how: Newflow::EducatorSignup::CompleteProfile::AS_FUTURE,
+                educator_specific_role: Newflow::EducatorSignup::CompleteProfile::INSTRUCTOR,
+              }
+            }
+          end
+
+          it "should not error" do
+            result = handle
+            expect(result.errors.count).to eq 0
+          end
+        end
+
         context 'books used details' do
           let(:educator_specific_role) { Newflow::EducatorSignup::CompleteProfile::INSTRUCTOR }