Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released versions of lev, openstax_transaction_isolation, openstax_transaction_retry and fine_print #1290

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

Dantemss
Copy link
Member

@Dantemss Dantemss commented Jan 2, 2025

There are still a few gems loaded from GitHub in the Gemfile, namely:

openstax/intl-tel-input-rails
openstax/path_prefixer
openstax/pattern-library

@Dantemss Dantemss requested a review from mwvolo January 2, 2025 16:55
@Dantemss Dantemss self-assigned this Jan 2, 2025
@mwvolo
Copy link
Member

mwvolo commented Jan 7, 2025

@Dantemss any ideas on why migrations are failing? Is there some kind of github actions cache in play here?
Seems strange all the other tests pass.

@Dantemss
Copy link
Member Author

Dantemss commented Jan 7, 2025

@mwvolo I noticed the cache action was running really slowly on that day, maybe related to GitHub deprecating cache v2 and/or Ubuntu 20... let's see if the retry works

@Dantemss
Copy link
Member Author

Dantemss commented Jan 7, 2025

On second thought, what is happening is the migration task tries to checkout the gems that were there before this PR to compare and it's trying to checkout the lev revision that was there before and that is failing for whatever reason. I think we can ignore.

@Dantemss Dantemss changed the title Use released versions of lev, openstax_transaction_isolation and openstax_transaction_retry Use released versions of lev, openstax_transaction_isolation, openstax_transaction_retry and fine_print Jan 7, 2025
@Dantemss Dantemss merged commit e8bb4ba into main Jan 7, 2025
5 of 8 checks passed
@Dantemss Dantemss deleted the update-gems branch January 7, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants