Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q preview support #177

Closed

Conversation

pcrepieux
Copy link
Contributor

Following the discussion for issue #168 this PR adds support for Android Q preview.

It is made of the following changes:

  • Dynamically load and call SurfaceComposerClient::getInternalDisplayToken() from libgui to replace SurfaceComposerClient::getBuiltInDisplay(int) in a new minicap_qpp4.cpp file. I tried to follow your naming convention as much as possible but decided to go with buildid rather than API level to better denotate the preview target
  • move the SurfaceComposerClient::Transaction scope to prevent a segfault (there must be some memory layout trickery that makes this works)
  • adds a check in run.sh to select the minicap-shared lib according to ro.build.id (as mentionned earlier)

I only added arm64-v8a target in the Makefile because I only tested on Pixel3 devices. I also pushed the binary because building it is a bit cumbersome and I wasn't sure whether you'd prefer to have it or not.

Dynamically load and call SurfaceComposerClient::getInternalDisplayToken()
from libgui to replace SurfaceComposerClient::getBuiltInDisplay(int).
This is a temporary fix until AOSP get fully updated.

Also adds a check in run.sh to select the minicap-shared lib
according to ro.build.id
@pcrepieux
Copy link
Contributor Author

As android 10 has been released and AOSP synced, this PR is somehow obsolete.
refer to #190 for Android Q support

@pcrepieux pcrepieux closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant