Make tax calculations based on appliedcost #96
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the line items are always being taxed based on their full price(totalcost) and this change should reflect any discounts that are applied to the item(appliedcost). I did test this for a single transaction which was accurate but it should be tested more thoroughly with vouchers, dealer discounts in addition to sales. I think the appliedcost is the right element to be using but you'll want to triple check that.
Potential fix for #95.