Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy-preview: Change link to paris #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deploy-preview: Change link to paris #1348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
body: `${start} You can preview the tagging presets of this pull request [here](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en).`
body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone version of iD does only look at the hash part of the url:

Suggested change
body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).`
body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#id=n17807753&locale=en).`

But for the above mentioned alternatives, using the map parameter would be more appropriate:

Suggested change
body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).`
body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466).`

});
} else {
console.log(`Preview URL comment already added to PR #${pullRequestNumber}`);
Expand Down
Loading