Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-METATILE code as it no longer seems to work #366

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Jan 6, 2024

I can't for the life of me figure out how to get it working without METATILE defined. There seem to be too many references to it which are not within an #ifdef directive block.

Also:

  • Removed hyphens/spaces from comments from meta-tile/meta-tiling/meta tile
    • In order to consolidate spellings

src/render_expired.c Dismissed Show dismissed Hide dismissed
src/render_expired.c Dismissed Show dismissed Hide dismissed
src/render_expired.c Dismissed Show dismissed Hide dismissed
src/render_old.c Dismissed Show dismissed Hide dismissed
src/render_list.c Dismissed Show dismissed Hide dismissed
src/render_list.c Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (19facb0) 71.90% compared to head (d4e12ed) 71.56%.

Files Patch % Lines
src/render_list.c 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   71.90%   71.56%   -0.34%     
==========================================
  Files          23       23              
  Lines        5527     5525       -2     
==========================================
- Hits         3974     3954      -20     
- Misses       1553     1571      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hummeltech hummeltech force-pushed the RemoveMetatileCode branch 2 times, most recently from 1fd7bc8 to 01eee59 Compare January 12, 2024 04:19
Remove unused reference to METATILEFALLBACK
Rewrote `meta tile`/`meta-tile` to `metatile`
@hummeltech hummeltech marked this pull request as draft June 22, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants