Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct h2c service appProtocol #77

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: correct h2c service appProtocol #77

merged 1 commit into from
Aug 15, 2024

Conversation

imdominicreed
Copy link
Contributor

Platform's service appProtocol is h2c. According to kubernetes docs, it should be kubernetes.io/h2c.

HTTP Requests were being received as HTTP/1.1, rather than HTTP2 causing gRPC requests to fail.

@imdominicreed imdominicreed requested a review from a team as a code owner August 15, 2024 20:05
@imdominicreed imdominicreed merged commit 25a1ae8 into main Aug 15, 2024
8 checks passed
@imdominicreed imdominicreed deleted the fix/h2c branch August 15, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants