fix: keySplitInfo Promise.any Promise.all #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
dmihalcik-virtru
previously approved these changes
Nov 12, 2024
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
pflynn-virtru
changed the title
pflynn-virtru
force-pushed
the
fix/split-unwrap
branch
from
4831910
to
f94c9e0
Compare
pflynn-virtru
changed the title
elizabethhealy
approved these changes
Nov 13, 2024
dmihalcik-virtru
approved these changes
Nov 13, 2024
Updated the import path for EntityObject to ensure correct module resolution. Added a comprehensive set of tests for the unwrapKey function to validate error handling and successful key unwrapping scenarios.
Parallelize the KAS key rewrap attempts within unwrapKey for improved efficiency. All potential KAS sources are now processed concurrently, and the method uses the first successful result, enhancing performance and robustness. Errors are collected and the most relevant one is thrown if all attempts fail.
Removed the entire unwrapKey.spec.ts test suite as it is no longer necessary. Minor formatting adjustments were made in the tdf.ts file.
Introduced comprehensive error handling tests for various HTTP status codes in encryption-decryption processes, including 400, 401, 403, and 500 HTTP errors. Adjusted the mock server to validate error conditions based on custom headers and handle network failures.
Simplify the KAS handling logic by using `Promise.any` to stop at the first successful response rather than waiting for all promises to complete. This ensures more efficient error handling and improves overall performance by immediately processing the first successful KAS response, while adequately handling AggregateErrors for failed attempts.
Updated the TypeScript configuration in both "lib" and "cli" projects to use ES2021 language features and modules. This change improves consistency and supports newer JavaScript features.
pflynn-virtru
force-pushed
the
fix/split-unwrap
branch
from
b704400
to
5c4707b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallelize the KAS key rewrap attempts within unwrapKey for improved efficiency.
OR Promise.any
All potential KAS sources are now processed concurrently, and the method uses the first successful result, enhancing performance and robustness.
AND Promise.all
Errors are collected and the most relevant one is thrown if all attempts fail.
"target": "es2021",DSP-287