Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Subtensor unnitests #2713

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

More Subtensor unnitests #2713

wants to merge 2 commits into from
+1,581 −3

Conversation

zyzniewski-reef
Copy link
Contributor

@zyzniewski-reef zyzniewski-reef commented Feb 27, 2025 •
edited
Loading

Coverage before:

  • total: 60.13%
  • subtensor: 62.44%

Coverage after:

  • total: 63.77%
  • subtensor: 87.90%

@zyzniewski-reef zyzniewski-reef force-pushed the tests/zyzniewski/more_subtensor_unittests branch from 33b3df2 to 302d52d Compare February 27, 2025 10:43
@zyzniewski-reef zyzniewski-reef mentioned this pull request Feb 27, 2025
Open
1 task
ibraheem-opentensor
ibraheem-opentensor reviewed Mar 4, 2025
View reviewed changes
tests/unit_tests/test_subtensor_new.py
)


# def test_get_vote_data(substrate, subtensor, mocker):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@ibraheem-opentensor
Copy link
Contributor

LGTM overall. I would change the the name of the file from test_subtensor_new to something more meaningful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheem-opentensor ibraheem-opentensor ibraheem-opentensor approved these changes

@roman-opentensor roman-opentensor Awaiting requested review from roman-opentensor

@thewhaleking thewhaleking Awaiting requested review from thewhaleking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyzniewski-reef @ibraheem-opentensor