chore: adjusting file locations (#2798)

Removing several duplicate scripts and adjusting the logic of others.
Also added missing achievements.

data-otservbr-global/scripts/actions/other/clay_lump.lua → data/scripts/actions/items/clay_lump.lua

@@ -8,31 +8,29 @@ local config = {
 local clayLump = Action()
 
 function clayLump.onUse(player, item, fromPosition, target, toPosition, isHotkey)
-	local random, tmpItem = math.random(0, 10000) * 0.01
-	for i = 1, #config do
-		tmpItem = config[i]
-		if random >= tmpItem.chance[1] and random < tmpItem.chance[2] then
+	local randomChance = math.random() * 100
+	for _, itemConfig in ipairs(config) do
+		if randomChance >= itemConfig.chance[1] and randomChance < itemConfig.chance[2] then
 			item:getPosition():sendMagicEffect(CONST_ME_POFF)
 
-			if tmpItem.remove then
+			if itemConfig.remove then
 				item:remove()
 			else
-				item:transform(tmpItem.transformId)
+				item:transform(itemConfig.transformId)
 			end
 
-			if tmpItem.sound then
-				player:say(tmpItem.sound, TALKTYPE_MONSTER_SAY, false, player)
+			if itemConfig.sound then
+				player:say(itemConfig.sound, TALKTYPE_MONSTER_SAY, false, player)
 			end
 
-			if tmpItem.description then
-				item:setDescription(tmpItem.description:gsub("|PLAYERNAME|", player:getName()))
+			if itemConfig.description then
+				item:setDescription(itemConfig.description:gsub("|PLAYERNAME|", player:getName()))
 			end
 
-			if tmpItem.achievement then
+			if itemConfig.achievement then
 				player:addAchievement("Clay Fighter")
 				player:addAchievementProgress("Clay to Fame", 5)
 			end
-
 			break
 		end
 	end

data-canary/scripts/actions/other/party_hat.lua → data/scripts/actions/items/party_hat.lua

@@ -7,6 +7,7 @@ function partyHat.onUse(player, item, fromPosition, target, toPosition, isHotkey
 	end
 
 	player:getPosition():sendMagicEffect(CONST_ME_GIFT_WRAPS)
+	player:addAchievementProgress("Party Animal", 200)
 	return true
 end
 

data-otservbr-global/scripts/movements/others/cake.lua → data/scripts/movements/cake.lua

@@ -1,7 +1,6 @@
 local cake = MoveEvent()
 
 function cake.onAddItem(moveitem, tileitem, position)
-	-- has to be a candle
 	if moveitem.itemid ~= 2918 then
 		return true
 	end