improve: only decay valid items

opentibiabr · Sep 17, 2023 · 98293c4 · 98293c4
1 parent aef87fc
commit 98293c4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/items/decay/decay.cpp b/src/items/decay/decay.cpp
@@ -114,9 +114,10 @@ void Decay::checkDecay() {
 
 		// Iterating here is unsafe so let's copy our items into temporary vector
 		auto &decayItems = it->second;
-		tempItems.reserve(tempItems.size() + decayItems.size());
-		for (auto &decayItem : decayItems) {
-			tempItems.push_back(decayItem.lock());
+		auto lockedDecayItems = weak::lock(decayItems);
+		tempItems.reserve(tempItems.size() + lockedDecayItems.size());
+		for (auto &decayItem : lockedDecayItems) {
+			tempItems.push_back(decayItem);
 		}
 		it = decayMap.erase(it);
 	}