fix: refresh bosstiary tracker kills on boss death (#1605)

I wasn't updating the deaths on the tracker when a new one was killed.
opentibiabr · Sep 16, 2023 · d65fb54 · d65fb54
1 parent 5f1f98e
commit d65fb54
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/src/creatures/players/player.cpp b/src/creatures/players/player.cpp
@@ -1654,9 +1654,6 @@ void Player::onCreatureAppear(Creature* creature, bool isLogin) {
 			}
 		}
 
-		// Reload bestiary tracker
-		refreshBestiaryMonsterTracker();
-
 		g_game().checkPlayersRecord();
 		IOLoginData::updateOnlineStatus(guid, true);
 		if (getLevel() < g_configManager().getNumber(ADVENTURERSBLESSING_LEVEL)) {

diff --git a/src/creatures/players/player.hpp b/src/creatures/players/player.hpp
@@ -303,8 +303,8 @@ class Player final : public Creature, public Cylinder, public Bankable {
 		}
 	}
 
-	void refreshBestiaryMonsterTracker() const {
-		refreshCyclopediaMonsterTracker(getCyclopediaMonsterTrackerSet(false), false);
+	void refreshCyclopediaMonsterTracker(bool isBoss = false) const {
+		refreshCyclopediaMonsterTracker(getCyclopediaMonsterTrackerSet(isBoss), isBoss);
 	}
 
 	void refreshCyclopediaMonsterTracker(const phmap::parallel_flat_hash_set<std::shared_ptr<MonsterType>> &trackerList, bool isBoss) const {

diff --git a/src/io/io_bosstiary.cpp b/src/io/io_bosstiary.cpp
@@ -176,6 +176,7 @@ void IOBosstiary::addBosstiaryKill(Player* player, const std::shared_ptr<Monster
 
 	auto oldBossLevel = getBossCurrentLevel(player, bossId);
 	player->addBestiaryKillCount(bossId, amount);
+	player->refreshCyclopediaMonsterTracker(true);
 	auto newBossLevel = getBossCurrentLevel(player, bossId);
 	if (oldBossLevel == newBossLevel) {
 		return;

diff --git a/src/io/iobestiary.cpp b/src/io/iobestiary.cpp
@@ -237,12 +237,8 @@ void IOBestiary::addBestiaryKill(Player* player, const std::shared_ptr<MonsterTy
 		}
 	}
 
-	const auto &trackerUnorderedSet = player->getCyclopediaMonsterTrackerSet(false);
-	for (const auto mType : trackerUnorderedSet) {
-		if (raceid == mType->info.raceid) {
-			player->refreshCyclopediaMonsterTracker(trackerUnorderedSet, false);
-		}
-	}
+	// Reload bestiary tracker
+	player->refreshCyclopediaMonsterTracker();
 }
 
 charmRune_t IOBestiary::getCharmFromTarget(Player* player, const std::shared_ptr<MonsterType> mtype) {