fix: possible crash related to getAttribute function

opentibiabr · Aug 30, 2023 · e29bd67 · e29bd67
1 parent e306e7b
commit e29bd67
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/items/item.hpp b/src/items/item.hpp
@@ -35,7 +35,7 @@ class Item;
 class ItemProperties {
 public:
 	template <typename T>
-	const T &getAttribute(ItemAttribute_t type) const {
+	T getAttribute(ItemAttribute_t type) const {
 		if constexpr (std::is_same_v<T, std::string>) {
 			return getString(type);
 		} else {
@@ -47,8 +47,7 @@ class ItemProperties {
 		}
 		g_logger().error("Failed to convert attribute for type {}", fmt::underlying(type));
 
-		static T defaultType;
-		return defaultType;
+		return {};
 	}
 
 	bool hasAttribute(ItemAttribute_t type) const {