Apply suggestions from code review

opentibiabr · Nov 13, 2024 · e7bab9f · e7bab9f
1 parent 561343d
commit e7bab9f
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/server/network/protocol/protocolgame.cpp b/src/server/network/protocol/protocolgame.cpp
@@ -4373,8 +4373,8 @@ void ProtocolGame::sendBlessingWindow() {
 
 	// Start at "The Wisdom Of Solitude"
 	uint8_t blessCount = 0;
-	for (int i = 2; i <= 8; i++) {
-		if (player->hasBlessing(i)) {
+	for (auto bless : magic_enum::enum_values<Blessings>()) {
+		if (player->hasBlessing(enumToValue(bless))) {
 			blessCount++;
 		}
 	}
@@ -4422,8 +4422,11 @@ void ProtocolGame::sendBlessStatus() {
 
 	// Ignore Twist of Fate (Id 1)
 	uint8_t blessCount = 0;
-	for (int i = 2; i <= 8; i++) {
-		if (player->hasBlessing(i)) {
+	for (auto bless : magic_enum::enum_values<Blessings>()) {
+		if (bless == Blessings::TwistOfFate) {
+			continue;
+		}
+		if (player->hasBlessing(enumToValue(bless))) {
 			blessCount++;
 		}
 	}