Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option in config to remove weapons with a chance of breaking #1544

Conversation

luanluciano93
Copy link
Contributor

Description

Putting option in config.lua to remove or not the weapons with a chance of breaking

Behaviour

Actual

currently to remove this chance it is necessary to adjust each item in the weapon/ folder

Type of change

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.20
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas
Copy link
Member

dudantas commented Sep 2, 2023

I don't know if this is a necessary change at the moment, in the pr #1494 we will completely remove the use of these lua scripts.
It might be interesting to wait until then.

@luanluciano93
Copy link
Contributor Author

ok

@luanluciano93 luanluciano93 deleted the removeWeaponWithBreakChance branch September 7, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants