Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple creature icons #1585

Merged
merged 4 commits into from
Sep 12, 2023
Merged

feat: multiple creature icons #1585

merged 4 commits into from
Sep 12, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Sep 10, 2023

The Tibia client can support up to 3 of these quest icons. And now so can we, you can manage these like so:

player:setIcon("magma-bubble", CreatureIconCategory_Quests, CreatureIconQuests_GreenShield, 0)
player:setIcon("something", CreatureIconCategory_Quests, CreatureIconQuests_Hazard, 5)
player:setIcon("something-else", CreatureIconCategory_Quests, CreatureIconQuests_WhiteCross, 15)

player:removeIcon("magma-bubble")
player:removeIcon("something")
player:removeIcon("something-else")

I've also migrated forge and hazard systems to use the new icons, which should in turn serve as a living example of how to use them.

Here's a demo:

Kapture.2023-09-10.at.00.52.12.mp4

@majestyotbr majestyotbr changed the title feat: mutliple creature icons feat: multiple creature icons Sep 10, 2023
@luan luan merged commit 0c7a52a into opentibiabr:main Sep 12, 2023
21 checks passed
@luan luan deleted the luan/multiicon branch September 12, 2023 06:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
3.0% 3.0% Duplication

JasterDesu pushed a commit to JasterDesu/canary that referenced this pull request Sep 16, 2023
The Tibia client can support up to 3 of these quest icons. And now so
can we, you can manage these like so:

```lua
player:setIcon("magma-bubble", CreatureIconCategory_Quests, CreatureIconQuests_GreenShield, 0)
player:setIcon("something", CreatureIconCategory_Quests, CreatureIconQuests_Hazard, 5)
player:setIcon("something-else", CreatureIconCategory_Quests, CreatureIconQuests_WhiteCross, 15)

player:removeIcon("magma-bubble")
player:removeIcon("something")
player:removeIcon("something-else")
```

I've also migrated forge and hazard systems to use the new icons, which
should in turn serve as a living example of how to use them.

Here's a demo:


https://github.com/opentibiabr/canary/assets/223760/937f9638-0155-4fb1-8c52-8957b5718e26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants