Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Game.getOutfits(playerSex) and Game.getMounts() #1673

Closed
wants to merge 15 commits into from
Closed

feat: Game.getOutfits(playerSex) and Game.getMounts() #1673

wants to merge 15 commits into from

Conversation

luanluciano93
Copy link
Contributor

Description

Adicionando as funções:

  • pushMount
  • Game.getOutfits(playerSex)
  • Game.getMounts()
  • Player.addAddonToAllOutfits(self, addon)
  • Player.addAllMounts(self)

Ainda não testei ...

@luanluciano93
Copy link
Contributor Author

@dudantas não estou conseguindo fazer funcionar, pode ajudar?

@dudantas
Copy link
Member

dudantas commented Oct 6, 2023

@dudantas não estou conseguindo fazer funcionar, pode ajudar?

No momento estou em período de provas na faculdade e não posso ajudar, mas deixe em draft que assim que desocupar eu ajudo sim.

@dudantas dudantas marked this pull request as draft October 6, 2023 13:40
@dudantas dudantas marked this pull request as ready for review October 6, 2023 13:41
@dudantas
Copy link
Member

@dudantas não estou conseguindo fazer funcionar, pode ajudar?

@luanluciano93 agora pode testar, arrumei.

@luanluciano93
Copy link
Contributor Author

  • Outfits: comando do god para add todos (/addaddons Tester) não funcionou.
  • Mounts: comando do god para add todos (/addaddons Tester) funcionou, porem dá uma travada de 1~2 segundos no servidor.

@dudantas dudantas marked this pull request as draft October 21, 2023 03:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.4% 0.4% Duplication

@dudantas dudantas closed this Nov 11, 2023
@luanluciano93 luanluciano93 deleted the getMountsAndOutfits branch November 15, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas left review comments

Assignees
No one assigned
Labels
Area: Datapack Core Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanluciano93 @dudantas