fix: fluid type must be within enum #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerotib
approved these changes
Oct 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
luan
approved these changes
Oct 10, 2023
luancolombo
added a commit
to luancolombo/nemesis
that referenced
this pull request
Oct 13, 2023
This reverts commit c8f7233.
luancolombo
added a commit
to luancolombo/nemesis
that referenced
this pull request
Oct 13, 2023
This reverts commit c02ec09.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Behaviour
Actual
Whenever auction is ended, the item count is set to 255, resulting in fluid type 255.
Expected
Whenever auction is ended, resulting fluid type should be between 0 and the size of fluid type enum.
Fixes #1535
Type of change