Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spell upgrade in wheel of destiny #1681

Merged
merged 7 commits into from
Oct 21, 2023

Conversation

sebbesiren
Copy link
Contributor

Removed an if-statement due to it preventing spells to be added to the list.
The nbr of spells in the list decides the upgrade grade of the spell.

Issue described in detail:

From my understanding of the code it:

  1. Calculate points for each slice of the wheel (red, green, purple etc.)
  2. Decide the grade the slice, which depends on total points spent in slice. The grades are 0, 1, 2, 3
  3. We then load the grade of the slice, lets say its the red slice and grade 2 and vocation sorcerer
  4. We then loop over the grade and add the Spell to the vector. Grade 2 should add 2 instances of the spell. Grade 3 should add 3 instances of the spell.
  5. Finally we loop over the vector and for every row we upgrade the spell. 2 instances of same spell => rank 2 of the spell

@luan
Copy link
Contributor

luan commented Oct 18, 2023

@sebbesiren can you allow github actions to push to your fork so the lua formatter succeeds?

@sebbesiren
Copy link
Contributor Author

@sebbesiren can you allow github actions to push to your fork so the lua formatter succeeds?

Yes, of course!

@sebbesiren
Copy link
Contributor Author

@sebbesiren can you allow github actions to push to your fork so the lua formatter succeeds?

Done

@dudantas dudantas merged commit f1eefb9 into opentibiabr:main Oct 21, 2023
13 of 21 checks passed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.5% 0.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants