-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: dispatch system #1685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit ae2b608 Author: Renato Machado <[email protected]> Date: Wed Oct 11 20:39:37 2023 -0300 improve commit 33163d6 Author: Renato Machado <[email protected]> Date: Wed Oct 11 19:07:51 2023 -0300 rework updateTargetList loop commit e4320e1 Author: Renato Machado <[email protected]> Date: Wed Oct 11 18:58:28 2023 -0300 fix crash on updateTargetList commit 73827db Author: Renato Machado <[email protected]> Date: Wed Oct 11 18:30:21 2023 -0300 Async Event Context / Cleanup commit d56e191 Author: Renato Machado <[email protected]> Date: Wed Oct 11 16:16:01 2023 -0300 addEvent_async commit 3e162ca Author: Renato Machado <[email protected]> Date: Wed Oct 11 15:30:41 2023 -0300 rework
luan
reviewed
Oct 11, 2023
* upstream/main: fix: bug reports for players with spaces in their name (#1694)
luan
approved these changes
Oct 13, 2023
luan
approved these changes
Oct 15, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch has been refactored to be centralized in just one thread. Previously, each task was sent to the threads that were free, which could cause bottlenecks because they were stuck with mutexes, causing queues depending on how many threads the cpu had.
small illustration of a possible problem:
Apart from what was mentioned above,, the scheduling class has been removed and we now have new methods in dispatch, addEvent_async, scheduleEvent and cycleEvent.
Note
Questions
Benchmark