feat: migrate boss cooldowns to KV #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
Oct 21, 2023
|
Kudos, SonarCloud Quality Gate passed! |
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 25, 2023
Fixed boss_death checks and log.
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 25, 2023
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 25, 2023
Fixed boss_death checks and log.
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 25, 2023
There are some bugs in the bosses that are killed individually, such as Flimsy and First Dragon |
|
|
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 28, 2023
Fixed boss_death checks and log.
elsongabriel
added a commit
to elsongabriel/canary
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting boss cooldowns is a kind of unnecessary pain. This makes it automatic and easy. Uses the Player's section of the KV store to automatically link bosses in by bestiary ID.