improve: move all onKill events to registed onDeath #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsongabriel
approved these changes
Oct 28, 2023
duuh30
approved these changes
Oct 29, 2023
dudantas
approved these changes
Oct 30, 2023
data-otservbr-global/scripts/actions/quests/the_dream_courts/bosses_killed.lua
Show resolved
Hide resolved
luan
force-pushed
the
luan/no-more-onkill
branch
from
0df66de to
1f72a76
Compare
|
Kudos, SonarCloud Quality Gate passed! |
marcusvcj
pushed a commit
to marcusvcj/canary
that referenced
this pull request
Nov 4, 2023
Alternative implementation of opentibiabr#1665 This change deprecates `onKill` (you'll get a warning if you try to use `onKill`, but it'll keep working until we decide to delete the callback from the source. Taking advantage of registed `onDeath` events and the fact that mechanics often use either damage map or the party of the top damage dealer. It also fixes a lot of inconsistencies in how kill tasks work, making most systems match what they should do when doing quests in a group. Full credit to @duuh30 for finding the issue and exploring the fix, and @beats-dh for helping with that. ## (very basic) benchmarks ### With this change (note, also includes opentibiabr#1757) ``` Average (Mean): Approximately 0.353 ms Median: Approximately 0.509 ms 95th Percentile (P95): 0.675 ms ``` ### Before this change ``` Average (Mean): Approximately 2998.6 ms Median: Approximately 2012.4 ms 95th Percentile (P95): 5997.9 ms ```
marcusvcj
pushed a commit
to marcusvcj/canary
that referenced
this pull request
Nov 20, 2023
Alternative implementation of opentibiabr#1665 This change deprecates `onKill` (you'll get a warning if you try to use `onKill`, but it'll keep working until we decide to delete the callback from the source. Taking advantage of registed `onDeath` events and the fact that mechanics often use either damage map or the party of the top damage dealer. It also fixes a lot of inconsistencies in how kill tasks work, making most systems match what they should do when doing quests in a group. Full credit to @duuh30 for finding the issue and exploring the fix, and @beats-dh for helping with that. ``` Average (Mean): Approximately 0.353 ms Median: Approximately 0.509 ms 95th Percentile (P95): 0.675 ms ``` ``` Average (Mean): Approximately 2998.6 ms Median: Approximately 2012.4 ms 95th Percentile (P95): 5997.9 ms ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #1665
This change deprecates
onKill(you'll get a warning if you try to useonKill, but it'll keep working until we decide to delete the callback from the source. Taking advantage of registedonDeathevents and the fact that mechanics often use either damage map or the party of the top damage dealer.It also fixes a lot of inconsistencies in how kill tasks work, making most systems match what they should do when doing quests in a group.
Full credit to @duuh30 for finding the issue and exploring the fix, and @beats-dh for helping with that.
(very basic) benchmarks
With this change (note, also includes #1757)
Before this change
Co-Authored-By: duuh30 [email protected]
Co-Authored-By: beats-dh [email protected]