Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some scripts #1784

Merged
merged 24 commits into from
Nov 13, 2023
Merged

fix: some scripts #1784

merged 24 commits into from
Nov 13, 2023

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented Nov 6, 2023 •
edited
Loading

Description

Continues fixing of #1741

  • Created a function to check time in levers and changed with creature:getStorageValue(config.storage) > os.time();
  • Adjusted save_interval messages;
  • Added check to show msg with payment information when traveling as free;
  • Fixed loot to custodian;
  • Fixed some typos;
  • Adjusted reward talkaction, to check cap;
  • Fixed adventurer's stone usage;
  • Added messages when starting or stopping using exercise weapons;
  • Fixed some events of bosses;

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary 3.1.1
  • Client: Tibia 13.21
  • Operating System: Windows/Ubuntu

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel force-pushed the hotfix/fix-scripts branch 3 times, most recently from 1c88d4e to a1a7977 Compare November 6, 2023 14:38
luanluciano93
luanluciano93 reviewed Nov 6, 2023
View reviewed changes
data-otservbr-global/scripts/actions/quests/dangerous_depth/gnomish_pesticide.lua Outdated Show resolved Hide resolved
data/events/scripts/player.lua Show resolved Hide resolved
data/scripts/reward_chest/boss_death.lua Outdated Show resolved Hide resolved
data/scripts/reward_chest/boss_death.lua Outdated Show resolved Hide resolved
data/scripts/talkactions/player/bank.lua Show resolved Hide resolved
data/scripts/talkactions/player/reward.lua Outdated Show resolved Hide resolved
luan
luan requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@luan luan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes that conflict with #1783. Also left some other minor comments.

data/scripts/reward_chest/boss_death.lua Outdated Show resolved Hide resolved
data-otservbr-global/scripts/actions/quests/forgotten_knowledge/last_lore_lever.lua Outdated Show resolved Hide resolved
data-otservbr-global/scripts/globalevents/customs/save_interval.lua Show resolved Hide resolved
data/events/scripts/player.lua Show resolved Hide resolved
data/items/items.xml Outdated Show resolved Hide resolved
data/libs/functions/player.lua Outdated Show resolved Hide resolved
@elsongabriel elsongabriel marked this pull request as draft November 8, 2023 15:02
@elsongabriel elsongabriel requested a review from luan November 11, 2023 19:31
@elsongabriel elsongabriel marked this pull request as ready for review November 11, 2023 19:31
@elsongabriel elsongabriel mentioned this pull request Nov 12, 2023
Closed
8 tasks
@elsongabriel elsongabriel self-assigned this Nov 12, 2023
This was linked to issues Nov 12, 2023
Adventurer Stone Error #1811
Closed
Dream Courts Bosses Lever Error #1808
Closed
luanluciano93
luanluciano93 reviewed Nov 13, 2023
View reviewed changes
data/scripts/reward_chest/boss_death.lua Outdated Show resolved Hide resolved
data/events/scripts/player.lua Outdated Show resolved Hide resolved
elsongabriel and others added 7 commits November 13, 2023 10:12
@elsongabriel
ssa exhaust fixes.
be8f3bf
@sebbesiren @elsongabriel
feat: custom pvp system (opentibiabr#1403)
f3a80c3 
Created two different systems to modify damage values in PvP. 

The first system is damage rate based on levelse. These are controller by three attributes in the config.lua. These have been added to the config.lua.dist.

The second system is damage rates based on vocations. This system is modified using vocations.xml. Added a new tag to the xml named pvp. Can control damage take and dealt per vocation.
@Leshyah @elsongabriel
fix: the outlaw camp quest (opentibiabr#1809)
c1db9e6
@luan @elsongabriel
fix: charge house rent (opentibiabr#1814)
8ce6e17 
Closes opentibiabr#987
@luan @elsongabriel
fix: bestiary kills and boss boost (opentibiabr#1813)
0964cdb 
Fixes opentibiabr#1804
@Schiffers @elsongabriel
feat: random monsters spawn (opentibiabr#1802)
def2251 
By using this commit you can choose if you want a "dinamic" respawn since it checks the monsters at the same spawn.
@luanluciano93 @elsongabriel
fix: table.remove function does not work with random indexes (opentib…
a763dd0 
…iabr#1801)
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit f7271db into opentibiabr:main Nov 13, 2023
10 checks passed
This was linked to issues Nov 13, 2023
Bugs Founded on (#1783) Forgotten knowledge #1788
Closed
Bosses_Warzone.lua can not index 'creature' (nil value). #1782
Closed
Dangerous_depths/lost_exile_task update is calling a nil value #1780
Closed
Player.lua error message #1688
Closed
@elsongabriel elsongabriel deleted the hotfix/fix-scripts branch November 14, 2023 11:38
@elsongabriel elsongabriel mentioned this pull request Nov 14, 2023
Merged
8 tasks
dudantas pushed a commit that referenced this pull request Nov 28, 2023
@elsongabriel
fix: some scripts (#1821)
83a823f 
Continues fixing of #1784 and #1847 

• Improved message on exercise_training.
• Fixes reward charges.
• Created flag in prison bosses' scripts to enable minus players and removed already created functions.
• Removed create torch when player login.
• Fixes in 'clearBossRoom' function usage on bosses teleports.
• Fixed count days and time on ferumbras_lever and fixed mechanic of Ascending Ferumbras boss.
• Fixed xp boost storage resetter (on very ss, the storage was being presented, and the player always buy it with 30 tc).
• Added 13.21 new mounts, reordered and fixed typos, changed the word moveable to movable.
• Removed unnecessary spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moviebr moviebr moviebr left review comments

@luanluciano93 luanluciano93 luanluciano93 left review comments

@dudantas dudantas dudantas approved these changes

@luan luan luan approved these changes

Assignees

@elsongabriel elsongabriel

Labels
Area: Datapack Core Area: Datapack Global
Projects
None yet
Milestone
No milestone
8 participants
@elsongabriel @luan @luanluciano93 @dudantas @moviebr @sebbesiren @Leshyah @Schiffers